breeze/FFmpeg
1
0
Fork 0
mirror of https://github.com/FFmpeg/FFmpeg.git synced 2026-02-04 14:30:55 +08:00
Code Issues Packages Projects Releases Wiki Activity
116,626 Commits 38 Branches 415 Tags
ea7375c9e94ee572d2cbe7ca25fc94ee8a5038b5
Commit Graph

26070 Commits

Author SHA1 Message Date
Stephen Hutchinson
ea7375c9e9 avformat/avisynth: move avs_planes* consts into relevant function 
These consts are only used in the switch(planar) case located in
avisynth_create_stream_video and nowhere else in the demuxer,
so move them into that function directly.

Signed-off-by: Stephen Hutchinson <qyot27@gmail.com>
 2024-08-13 15:09:53 -04:00
Stephen Hutchinson
48d6cd35a2 avformat/avisynth: remove library allocation from global state 
As part of this, the mutexes are no longer necessary, and
avisynth_read_close needs to check that avs->avs_library.library
still exists before it attempts to call avisynth_context_destroy
and dlclose.

Signed-off-by: Stephen Hutchinson <qyot27@gmail.com>
 2024-08-13 15:09:53 -04:00
Stephen Hutchinson
8f01ce2898 avformat/avisynth: remove mutex lock from avisynth_read_close 
Signed-off-by: Stephen Hutchinson <qyot27@gmail.com>
 2024-08-13 15:09:53 -04:00
Stephen Hutchinson
c0fddbae79 avformat/avisynth: remove atexit() handler 
The atexit() handler in the avisynth demuxer was added because
there was a conflict in AvxSynth that arose due to their use
of C++ global objects, particularly in relation to having
added a logging function relying on log4cpp.

This conflict was responsible for causing a segfault on exit.
It did not affect Windows with the (at the time) upstream
AviSynth 2.5 and 2.6, nor does it affect AviSynth+.

Unfortunately, none of this was actually shielded by ifdefs
indicating the fact it was only needed for AvxSynth, so four
years ago when AviSynth+ replaced AvxSynth as the handler
for AviSynth scripts on Unix-like OSes, the fact that the
atexit handler was no longer necessary was overlooked.

Signed-off-by: Stephen Hutchinson <qyot27@gmail.com>
 2024-08-13 15:09:53 -04:00
James Almer
472fbee812 avformat/movenc: don't look at previous track_id as it may not be set 
Signed-off-by: James Almer <jamrial@gmail.com>
 2024-08-12 11:41:38 -03:00
Michael Niedermayer
191a685010 avformat/lmlm4: Eliminate some AVERROR(EIO) 
Found by code review related to CID732224 Overflowed constant

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-08-11 13:21:12 +02:00
Michael Niedermayer
239f7e6c71 avformat/lmlm4: Move subtraction after check 
This is not a bugfix in code but coverity only, it does look a little nicer though

Fixes: CID732224

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-08-11 13:21:11 +02:00
Michael Niedermayer
c390234da2 avformat/wtvdec: Check length of read mpeg2_descriptor 
Fixes: Use of uninitialized value
Fixes: 70900/clusterfuzz-testcase-minimized-ffmpeg_dem_WTV_fuzzer-6286909377150976

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Reviewed-by: Peter Ross <pross@xvid.org>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-08-08 19:10:05 +02:00
Michael Niedermayer
c95ea03104 avformat/wtvdec: clear sectors 
The code can leave uninitialized holes in the array.
Fixes: use of uninitialized values
Fixes: 70883/clusterfuzz-testcase-minimized-ffmpeg_dem_WTV_fuzzer-6698694567591936

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Reviewed-by: Peter Ross <pross@xvid.org>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-08-08 18:24:31 +02:00
Kacper Michajłow
b534e402d8 avformat/mov: ensure required number of bytes is read 
Fixes: use-of-uninitialized-value

Found by OSS-Fuzz.

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-08-08 18:23:39 +02:00
James Almer
94165d1b79 avformat/iamf: use aligned intreadwrite macros where possible 
Signed-off-by: James Almer <jamrial@gmail.com>
 2024-08-07 00:16:21 -03:00
James Almer
49a6e448d7 avformat/movenc: use stream indexes when generating track ids 
In some scenarios nb_tracks isn't the same as nb_streams, so a given id may end
up being used for two separate streams.

e.g. when muxing an IAMF track followed by a video track, if the IAMF track
consists of several streams, the video track would end up having an id of 2,
which may also be used by one of the IAMF streams.

Signed-off-by: James Almer <jamrial@gmail.com>
 2024-08-07 00:16:21 -03:00
Kacper Michajłow
792a9979eb avformat/rtpproto: free ip filters on open error 
Found by OSS-Fuzz.

Signed-off-by: Kacper Michajłow <kasper93@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-08-07 00:59:19 +02:00
Kacper Michajłow
8485f7a378 avformat/srtpproto: pass options to nested protocol 
This fixes passing options dict.

Fixes some timeouts found by OSS-Fuzz.

Signed-off-by: Kacper Michajłow <kasper93@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-08-07 00:59:19 +02:00
Kacper Michajłow
2b5f000d3f avformat/jpegxl_anim_dec: ensure input padding is zeroed 
Fixes use of uninitialized value, reported by MSAN.

Found by OSS-Fuzz.

Signed-off-by: Kacper Michajłow <kasper93@gmail.com>

Fixes: 70837/clusterfuzz-testcase-minimized-ffmpeg_dem_JPEGXL_ANIM_fuzzer-5089407768526848
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-08-05 23:17:46 +02:00
Michael Niedermayer
3978e81809 avformat/img2dec: Clear padding data after EOF 
Fixes: use-of-uninitialized-value
Fixes: 70852/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-5179190066872320

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Reviewed-by: Kacper Michajlow <kasper93@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-08-05 23:17:46 +02:00
Michael Niedermayer
79a1cf30d1 avformat/wavdec: Check if there are 16 bytes before testing them 
Fixes: use-of-uninitialized-value
Fixes: 70839/clusterfuzz-testcase-minimized-ffmpeg_dem_W64_fuzzer-5212907590189056

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-08-05 23:17:45 +02:00
James Almer
5b87869c09 avformat/mov: fix track handling when mixing IAMF and video tracks 
Fixes crashes when muxing the two together.

Signed-off-by: James Almer <jamrial@gmail.com>
 2024-08-04 12:09:40 -03:00
Michael Niedermayer
ed96ac87a9 avformat/iamf_parse: Check for 0 samples 
Fixes: division by zero
Fixes: 70561/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-6199435013455872
Fixes: 70565/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-5783790316748800

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Reviewed-by: James Almer <jamrial@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-08-01 00:18:02 +02:00
James Almer
92b317245c avformat/mov: use AV_WL*A 
Signed-off-by: James Almer <jamrial@gmail.com>
 2024-07-29 21:33:31 -03:00
James Almer
f1fcc3ca5f avformat/matroskadec: use AV_WL32A 
Signed-off-by: James Almer <jamrial@gmail.com>
 2024-07-29 21:33:31 -03:00
James Almer
e7d3ff8dcd avformat/mov: check that child boxes of trak are only present inside it 
Based on the check done for the stco box.

Signed-off-by: James Almer <jamrial@gmail.com>
 2024-07-28 17:28:19 -03:00
James Almer
2aa63784b5 avformat/mov: check that sample and chunk count is 1 for HEIF 
Fixes NULL pointer dereference in broken/fuzzed streams.

Signed-off-by: James Almer <jamrial@gmail.com>
 2024-07-28 17:28:19 -03:00
Niklas Haas
3d5d60d041 avformat/dump: implement dv_md_compression 2024-07-28 12:20:07 +02:00
Niklas Haas
ce8166a19c avformat/mpegts: implement dv_md_compression 2024-07-28 12:20:07 +02:00
Niklas Haas
b3a9fab9da avformat/dovi_isom: implement dv_md_compression 2024-07-28 12:20:07 +02:00
Michael Niedermayer
586f6fda1d avformat/mov: add an EOF check in IPRP 
Fixes: Timeout
Fixes: 69230/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-6540512101203968

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-23 23:21:13 +02:00
Michael Niedermayer
55af81b5a4 Revert "avformat/udp: Fix temporary buffer race" 
This is not needed

This reverts commit 7b2f67ea77.
 2024-07-23 23:21:13 +02:00
aaron
53d0f9afb4 avcodec/electronicarts: decode framerate 
Reviewed-by: Peter Ross <pross@xvid.org>
 2024-07-23 06:40:30 +10:00
Michael Niedermayer
696685df0c avformat/xmv: Check this_packet_size 
Fixes: CID1604489 Overflowed constant

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-21 17:02:12 +02:00
Michael Niedermayer
7734c583f7 avformat/webpenc: Check filesize in trailer 
not sure this is possible

Fixes: CID1604446 Overflowed constant

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-21 17:02:12 +02:00
Michael Niedermayer
be30913538 avformat/ty: rec_size seems to only need 32bit 
May help CID1604560 Overflowed integer argument

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-21 17:02:11 +02:00
Michael Niedermayer
41745e550a avformat/tty: Check avio_size() 
Fixes: CID1220824 Overflowed constant

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-21 17:02:11 +02:00
Michael Niedermayer
124a97dd8b avformat/siff: Basic pkt_size check 
Fixes: half of CID1258461 Overflowed constant

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-21 17:02:11 +02:00
Michael Niedermayer
759aae590c avformat/sauce: Check avio_size() for failure 
Fixes: CID1604592 Overflowed constant

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-21 17:02:10 +02:00
Michael Niedermayer
3e305a0e70 avformat/sapdec: Check ffurl_get_file_handle() for error 
Fixes: CID1604506 Overflowed constant

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-21 16:41:51 +02:00
Michael Niedermayer
e83e246504 avformat/nsvdec: Check asize for PCM 
Fixes: CID1604527 Overflowed constant

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-21 16:41:43 +02:00
Michael Niedermayer
cea4dbc903 avformat/mp3dec: Check header_filesize 
Fixes: CID1608714 Division or modulo by float zero

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-21 16:41:41 +02:00
Michael Niedermayer
bb936a1a72 avformat/mp3dec; Check for avio_size() failure 
Fixes: CID1608710 Improper use of negative value

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-21 16:41:37 +02:00
Michael Niedermayer
046d069552 avformat/mov: Use 64bit for str_size 
We assign a 64bit variable to it before checking

Fixes: CID1604544 Overflowed integer argument

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-21 16:41:35 +02:00
Michael Niedermayer
139bf41246 avformat/mm: Check length 
Fixes: CID1220824 Overflowed constant

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-21 16:41:32 +02:00
Michael Niedermayer
291356f58b avformat/hnm: Check *chunk_size 
Fixes: CID1604419 Overflowed constant

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-21 16:41:23 +02:00
Michael Niedermayer
7e577165c1 avformat/hlsenc: Check ret 
Fixes: CID1609624 Unused value

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-21 16:41:11 +02:00
Michael Niedermayer
bf61f811e7 avformat/bintext: Check avio_size() return 
Fixes: CID1604503 Overflowed constant
Fixes: CID1604566 Overflowed constant

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-21 16:40:49 +02:00
Michael Niedermayer
891bc070f0 avformat/asfdec_o: Check size of index object 
We subtract 24 so it must be at least 24

Fixes: CID1604482 Overflowed constant

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-21 16:40:48 +02:00
Michael Niedermayer
9b9e02f2ff avformat/iamf_parse: Check for negative sample sizes 
Fixes: index -2 out of bounds for type 'const enum AVCodecID [3]'
Fixes: 69866/clusterfuzz-testcase-minimized-ffmpeg_dem_IAMF_fuzzer-4971166119821312

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-21 15:35:08 +02:00
Michael Niedermayer
d8d288479d avformat/mxfdec: Reorder elements of expression in bisect loop 
Fixes: signed integer overflow: 9223372036854775807 - -1 cannot be represented in type 'long'
Fixes: 68578/clusterfuzz-testcase-minimized-ffmpeg_dem_MXF_fuzzer-6032171648221184

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-21 15:29:25 +02:00
Michael Niedermayer
167bf8f61e avformat/mov: Check extradata in mov_read_iacb() 
Fixes: MemLeak
Fixes: 69853/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-4660448545275904

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-21 15:29:24 +02:00
James Almer
2aab4e4cc0 avformat/iamf_writer: disallow Opus extradata with mapping family other than 0 
Clause 3.11.1 of IAMF[1] states the Opus ID Header should conform to  ChannelMappingFamily == 0.

[1]https://aomediacodec.github.io/iamf/#opus-specific

Signed-off-by: James Almer <jamrial@gmail.com>
 2024-07-19 21:07:32 -03:00
James Almer
9ce065c90d avformat/iamf_parse: sanitize audio_roll_distance values 
Ensure the values are spec complaint and that no integer overflow can happen.

Signed-off-by: James Almer <jamrial@gmail.com>
 2024-07-19 21:07:32 -03:00