mirror of
https://github.com/FFmpeg/FFmpeg.git
synced 2026-02-04 14:30:55 +08:00
bc109a53c7
These tables are only used by encoders and only for the current picture; ergo they need not be put into the picture at all, but rather into the encoder's context. They also don't need to be refcounted, because there is only one owner. In contrast to this, the earlier code refcounts them which incurs unnecessary overhead. These references are not unreferenced in ff_mpeg_unref_picture() (they are kept in order to have something like a buffer pool), so that several buffers are kept at the same time, although only one is needed, thereby wasting memory. The code also propagates references to other pictures not part of the pictures array (namely the copy of the current/next/last picture in the MpegEncContext which get references of their own). These references are not unreferenced in ff_mpeg_unref_picture() (the buffers are probably kept in order to have something like a pool), yet if the current picture is a B-frame, it gets unreferenced at the end of ff_mpv_encode_picture() and its slot in the picture array will therefore be reused the next time; but the copy of the current picture also still has its references and therefore these buffers will be made duplicated in order to make them writable in the next call to ff_mpv_encode_picture(). This is of course unnecessary. Finally, ff_find_unused_picture() is supposed to just return any unused picture and the code is supposed to work with it; yet for the vsynth*-mpeg4-adap tests the result depends upon the content of these buffers; given that this patchset changes the content of these buffers (the initial content is now the state of these buffers after encoding the last frame; before this patch the buffers used came from the last picture that occupied the same slot in the picture array) their ref-files needed to be changed. This points to a bug somewhere (if one removes the initialization, one gets uninitialized reads in adaptive_quantization in ratecontrol.c). Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
108 lines
3.6 KiB
C
108 lines
3.6 KiB
C
/*
|
|
* Mpeg video formats-related defines and utility functions
|
|
*
|
|
* This file is part of FFmpeg.
|
|
*
|
|
* FFmpeg is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* FFmpeg is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with FFmpeg; if not, write to the Free Software
|
|
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
|
|
*/
|
|
|
|
#ifndef AVCODEC_MPEGPICTURE_H
|
|
#define AVCODEC_MPEGPICTURE_H
|
|
|
|
#include <stdint.h>
|
|
|
|
#include "libavutil/frame.h"
|
|
|
|
#include "avcodec.h"
|
|
#include "motion_est.h"
|
|
#include "threadframe.h"
|
|
|
|
#define MPEGVIDEO_MAX_PLANES 4
|
|
#define MAX_PICTURE_COUNT 36
|
|
#define EDGE_WIDTH 16
|
|
|
|
typedef struct ScratchpadContext {
|
|
uint8_t *edge_emu_buffer; ///< temporary buffer for if MVs point to out-of-frame data
|
|
uint8_t *rd_scratchpad; ///< scratchpad for rate distortion mb decision
|
|
uint8_t *obmc_scratchpad;
|
|
uint8_t *b_scratchpad; ///< scratchpad used for writing into write only buffers
|
|
} ScratchpadContext;
|
|
|
|
/**
|
|
* Picture.
|
|
*/
|
|
typedef struct Picture {
|
|
struct AVFrame *f;
|
|
ThreadFrame tf;
|
|
|
|
AVBufferRef *qscale_table_buf;
|
|
int8_t *qscale_table;
|
|
|
|
AVBufferRef *motion_val_buf[2];
|
|
int16_t (*motion_val[2])[2];
|
|
|
|
AVBufferRef *mb_type_buf;
|
|
uint32_t *mb_type; ///< types and macros are defined in mpegutils.h
|
|
|
|
AVBufferRef *mbskip_table_buf;
|
|
uint8_t *mbskip_table;
|
|
|
|
AVBufferRef *ref_index_buf[2];
|
|
int8_t *ref_index[2];
|
|
|
|
int alloc_mb_width; ///< mb_width used to allocate tables
|
|
int alloc_mb_height; ///< mb_height used to allocate tables
|
|
int alloc_mb_stride; ///< mb_stride used to allocate tables
|
|
|
|
AVBufferRef *hwaccel_priv_buf;
|
|
void *hwaccel_picture_private; ///< Hardware accelerator private data
|
|
|
|
int field_picture; ///< whether or not the picture was encoded in separate fields
|
|
|
|
int64_t mb_var_sum; ///< sum of MB variance for current frame
|
|
int64_t mc_mb_var_sum; ///< motion compensated MB variance for current frame
|
|
|
|
int b_frame_score;
|
|
int needs_realloc; ///< Picture needs to be reallocated (eg due to a frame size change)
|
|
|
|
int reference;
|
|
int shared;
|
|
|
|
uint64_t encoding_error[MPEGVIDEO_MAX_PLANES];
|
|
} Picture;
|
|
|
|
/**
|
|
* Allocate a Picture.
|
|
* The pixels are allocated/set by calling get_buffer() if shared = 0.
|
|
*/
|
|
int ff_alloc_picture(AVCodecContext *avctx, Picture *pic, MotionEstContext *me,
|
|
ScratchpadContext *sc, int shared, int encoding,
|
|
int chroma_x_shift, int chroma_y_shift, int out_format,
|
|
int mb_stride, int mb_width, int mb_height, int b8_stride,
|
|
ptrdiff_t *linesize, ptrdiff_t *uvlinesize);
|
|
|
|
int ff_mpeg_framesize_alloc(AVCodecContext *avctx, MotionEstContext *me,
|
|
ScratchpadContext *sc, int linesize);
|
|
|
|
int ff_mpeg_ref_picture(AVCodecContext *avctx, Picture *dst, Picture *src);
|
|
void ff_mpeg_unref_picture(AVCodecContext *avctx, Picture *picture);
|
|
|
|
void ff_mpv_picture_free(AVCodecContext *avctx, Picture *pic);
|
|
int ff_update_picture_tables(Picture *dst, const Picture *src);
|
|
|
|
int ff_find_unused_picture(AVCodecContext *avctx, Picture *picture, int shared);
|
|
|
|
#endif /* AVCODEC_MPEGPICTURE_H */
|