mirror of
https://mirrors.tuna.tsinghua.edu.cn/git/glibc.git
synced 2026-01-12 00:20:19 +08:00
3dd2cbfa35
commit 7fec8a5de6
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date: Thu Nov 13 14:26:08 2025 -0300
Revert __HAVE_64B_ATOMICS configure check
uses 64-bit atomic operations on sem_t if 64-bit atomics are supported.
But sem_t may be aligned to 32-bit on 32-bit architectures.
1. Add a macro, SEM_T_ALIGN, for sem_t alignment.
2. Add a macro, HAVE_UNALIGNED_64B_ATOMICS. Define it if unaligned 64-bit
atomic operations are supported.
3. Add a macro, USE_64B_ATOMICS_ON_SEM_T. Define to 1 if 64-bit atomic
operations are supported and SEM_T_ALIGN is at least 8-byte aligned or
HAVE_UNALIGNED_64B_ATOMICS is defined.
4. Assert that size and alignment of sem_t are not lower than those of
the internal struct new_sem.
5. Check USE_64B_ATOMICS_ON_SEM_T, instead of USE_64B_ATOMICS, when using
64-bit atomic operations on sem_t.
This fixes BZ #33632.
Reviewed-by: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
80 lines
1.8 KiB
C
80 lines
1.8 KiB
C
#include <errno.h>
|
|
#include <semaphore.h>
|
|
#include <stdio.h>
|
|
#include <unistd.h>
|
|
#include <pthread.h>
|
|
#include <internaltypes.h>
|
|
#include <support/check.h>
|
|
|
|
/* A bogus clock value that tells run_test to use sem_timedwait rather than
|
|
sem_clockwait. */
|
|
#define CLOCK_USE_TIMEDWAIT (-1)
|
|
|
|
typedef int (*waitfn_t)(sem_t *, struct timespec *);
|
|
|
|
static void
|
|
do_test_wait (waitfn_t waitfn, const char *fnname)
|
|
{
|
|
union
|
|
{
|
|
sem_t s;
|
|
struct new_sem ns;
|
|
} u;
|
|
|
|
printf ("do_test_wait: %s\n", fnname);
|
|
|
|
TEST_COMPARE (sem_init (&u.s, 0, 0), 0);
|
|
|
|
struct timespec ts = { 0, 1000000001 }; /* Invalid. */
|
|
errno = 0;
|
|
TEST_VERIFY_EXIT (waitfn (&u.s, &ts) < 0);
|
|
TEST_COMPARE (errno, EINVAL);
|
|
|
|
#if USE_64B_ATOMICS_ON_SEM_T
|
|
unsigned int nwaiters = (u.ns.data >> SEM_NWAITERS_SHIFT);
|
|
#else
|
|
unsigned int nwaiters = u.ns.nwaiters;
|
|
#endif
|
|
TEST_COMPARE (nwaiters, 0);
|
|
|
|
ts.tv_sec = /* Invalid. */ -2;
|
|
ts.tv_nsec = 0;
|
|
errno = 0;
|
|
TEST_VERIFY_EXIT (waitfn (&u.s, &ts) < 0);
|
|
TEST_COMPARE (errno, ETIMEDOUT);
|
|
#if USE_64B_ATOMICS_ON_SEM_T
|
|
nwaiters = (u.ns.data >> SEM_NWAITERS_SHIFT);
|
|
#else
|
|
nwaiters = u.ns.nwaiters;
|
|
#endif
|
|
TEST_COMPARE (nwaiters, 0);
|
|
}
|
|
|
|
int test_sem_timedwait (sem_t *sem, struct timespec *ts)
|
|
{
|
|
return sem_timedwait (sem, ts);
|
|
}
|
|
|
|
int test_sem_clockwait_monotonic (sem_t *sem, struct timespec *ts)
|
|
{
|
|
return sem_clockwait (sem, CLOCK_MONOTONIC, ts);
|
|
}
|
|
|
|
int test_sem_clockwait_realtime (sem_t *sem, struct timespec *ts)
|
|
{
|
|
return sem_clockwait (sem, CLOCK_REALTIME, ts);
|
|
}
|
|
|
|
static int do_test (void)
|
|
{
|
|
do_test_wait (&test_sem_timedwait,
|
|
"sem_timedwait");
|
|
do_test_wait (&test_sem_clockwait_monotonic,
|
|
"sem_clockwait(monotonic)");
|
|
do_test_wait (&test_sem_clockwait_realtime,
|
|
"sem_clockwait(realtime)");
|
|
return 0;
|
|
}
|
|
|
|
#include <support/test-driver.c>
|