257 Commits

Author SHA1 Message Date
Simon Josefsson
8e9d7c933a doc: Fix codespell nits 2025-11-27 00:33:35 +01:00
Collin Funk
8e88c32cfe maint: Fix link errors on Solaris 11 OmniOS.
* bootstrap.conf (gnulib_modules): Add hostent and socket.
* ftp/Makefile.am (ftp_LDADD): New variable.
* ftpd/Makefile.am (ftpd_LDADD): New variable.
* ifconfig/Makefile.am (ifconfig_LDADD): New variable.
* ping/Makefile.am (ping_LDADD): Add $(LIBSOCKET), $(HOSTENT_LIB),
$(LIBINTL), and $(GETADDRINFO_LIB).
(ping6_LDADD): New variable.
* src/Makefile.am (hostname_LDADD, rlogin_LDADD, rsh_LDADD): Add
$(HOSTENT_LIB).
(tftp_LDADD, rexecd_LDADD): Add $(LIBSOCKET).
(rexec_LDADD, dnsdomainname_LDADD, logger_LDADD, inetd_LDADD)
(tftpd_LDADD): New variables.
(rlogind_LDADD): Add $(LIBSOCKET), $(LIBINTL), and $(GETADDRINFO_LIB).
(rshd_LDADD): Add $(HOSTENT_LIB), $(LIBINTL), and $(GETADDRINFO_LIB).
(syslogd_LDADD): Add $(LIBSOCKET), $(HOSTENT_LIB), $(LIBINTL), and
$(GETADDRINFO_LIB).
(uucpd_LDADD): Add $(LIBSOCKET) and $(HOSTENT_LIB).
* talk/Makefile.am (talk_LDADD): New variable.
* talkd/Makefile.am (talkd_LDADD): New variable.
* telnet/Makefile.am (telnet_LDADD): New variable.
* telnetd/Makefile.am (telnetd_LDADD): New variable.
* tests/Makefile.am (localhost_LDADD, runtime_ipv6_LDADD)
(addrpeek_LDADD, tcpget_LDADD): New variables.
* whois/Makefile.am (whois_LDADD): New variable.
2025-02-25 22:36:20 -08:00
Simon Josefsson
04c3738a6c maint: Run 'make update-copyright'. 2025-01-01 18:21:25 +01:00
Collin Funk
e5a9384c92 maint: Remove unnecessary standard library extern function decls.
* ftp/cmds.c (account, user): Don't declare getpass since it is
defined in unistd.h.
* ftp/ftp.c (login): Likewise. Don't declare fclose and pclose since
they are defined in stdio.h.
* ftpd/extern.h: Don't declare getusershell since it is defined in
unistd.h.
* ftpd/ftpd.c: Don't declare fclose since it is defined in stdio.h.
* libinetutils/logwtmp.c: Don't declare errno since it is defined in
errno.h.
* libtelnet/misc.c (auth_encrypt_user): Include string.h and don't
declare strdup.
* telnet/authenc.c (telnet_gets):  Don't declare getpass since it is
defined in unistd.h.
* telnet/commands.c (hostname): Use NULL instead of 0.
(env_init, shell): Include string.h and don't redeclare functions.
2024-05-08 20:29:36 -07:00
Collin Funk
b5888324ce Fix sc_unsigned_int checks.
* ftpd/ftpd.c (send_data, receive_data): Convert 'u_int' to
'unsigned int'.
* libinetutils/ttymsg.c (inetutils_ttymsg): Likewise.
* libls/extern.h: Likewise.
* libls/print.c (minor, printtype): Likewise.
* libls/stat_flags.c (flags_to_string, string_to_flags): Likewise.
* src/rlogin.c (winsize, get_window_size, getescape): Likewise.
* src/rsh.c (copyargs): Likewise.
2024-05-04 01:42:20 -07:00
Simon Josefsson
aba8d6528e maint: Run 'make update-copyright'. 2024-01-01 11:28:59 +01:00
Simon Josefsson
2cf199580a maint: Re-indent using GNU indent 2.2.13. 2023-12-29 18:35:01 +01:00
Jeffrey Bencteux
e4e65c03f4 ftpd,rcp,rlogin,rsh,rshd,uucpd: fix: check set*id() return values
Several setuid(), setgid(), seteuid() and setguid() return values
were not checked in ftpd/rcp/rlogin/rsh/rshd/uucpd code potentially
leading to potential security issues.

Signed-off-by: Jeffrey Bencteux <jeffbencteux@gmail.com>
Signed-off-by: Simon Josefsson <simon@josefsson.org>
2023-07-31 13:58:34 +02:00
Simon Josefsson
4bfe18d36f maint: Run 'make update-copyright'. 2023-01-01 01:37:41 +01:00
Simon Josefsson
c1b8d134d5 Indent code. 2022-10-26 00:03:45 +02:00
Alfred M. Szmidt
6d519229fa Happy GNU 2022 year! 2022-01-01 17:23:02 +01:00
Simon Josefsson
1d5c923528 maint: Use copyright year ranges for readability.
* cfg.mk (update-copyright-env): Add, from coreutils.
(VC_LIST_ALWAYS_EXCLUDE_REGEX): Add, for update-copyright exceptions.
* README: Add info about copyright year ranges.
* *: Update copyright notices.
2021-09-03 18:41:09 +02:00
Simon Josefsson
0ceee23262 Use gnulib module 'attribute' instead of obsolete 'snippets/unused-parameters'.
* */*.c: Use MAYBE_UNUSED instead of _GL_UNUSED_PARAMETER.
* */*.c: Include attribute.h instead of unused-parameters.h.
2021-09-01 22:49:18 +02:00
Alfred M. Szmidt
911413ea57 Happy GNU 2021 year! 2021-01-01 11:35:27 +01:00
Tim Rühsen
46def33024 ftpd: Fix multiple definition of 'errcatch' (gcc 10) 2020-02-29 18:37:20 +01:00
Mats Erik Andersson
71ece60ff8 Minor portability glitches in Solaris and in AIX. 2020-01-18 17:47:05 +01:00
Simon Josefsson
d8de4587f2 Update copyright years to use intervals up to 2020. 2020-01-01 13:21:37 +01:00
Alfred M. Szmidt
7f221ff1f9 ftpd/ftpd.c (options) <max-timeout>: Mention mandatory argument. 2017-07-10 19:59:44 +00:00
Mats Erik Andersson
3d64a8c728 Update copyright years to 2017. (silent change) 2017-02-21 14:25:23 +01:00
Mats Erik Andersson
84dcf08568 Update copyright years to 2016. (silent change) 2016-01-22 19:09:49 +01:00
Mats Erik Andersson
055ea0a73f Fix sc_prohibit_double_semicolon. 2015-04-17 15:38:22 +02:00
Mats Erik Andersson
d3c9b1b8fa Update copyright years with 2015. (silent change) 2015-01-16 14:09:44 +01:00
Giuseppe Scrivano
abb0bed745 build: fix syntax-check 2014-07-01 12:21:09 +02:00
Mats Erik Andersson
88bf387782 ftpd: Parse commands in RFC 2228.
Let the parser recognize these security
extensions, but mark them as unimplemented.
2014-02-10 22:49:05 +01:00
Mats Erik Andersson
ae85332551 Update copyright years with 2014. (silent change) 2014-01-18 12:23:21 +01:00
Mats Erik Andersson
00eb52f913 ftpd: Follow RFC 2577 by default.
With the aim of preventing user name enumeration,
the standard behaviour is changed to fake a password
exchange when a user name fails to exist.
2013-12-13 12:09:11 +01:00
Mats Erik Andersson
1d9298cfaf ftpd: Capture syntax errors.
Scanner and parser were not sufficiently tuned
to each other, and could produce inconclusive
error messages and even duplicate messages from
a single error.
2013-10-04 23:10:15 +02:00
Mats Erik Andersson
88488ebc5a ftpd: Implement FEAT and OPTS.
Satisfy RFC 2389 for improved standard.
2013-09-26 20:56:32 +02:00
Mats Erik Andersson
58da4a7168 ftp: Abort transfer in ascii mode. 2013-09-26 01:23:55 +02:00
Mats Erik Andersson
5f59063e2b ftpd: Setting of idle time.
The command to change idle time was broken.
2013-09-26 00:36:20 +02:00
Mats Erik Andersson
06123506ea ftpd: Status reveals timeout. 2013-08-31 01:46:25 +02:00
Mats Erik Andersson
309ba4a541 Portability of Unix macros. 2013-08-30 15:56:19 +02:00
Mats Erik Andersson
7795fb389e ftpd: Prevent disclosure of system version. 2013-06-26 19:07:30 +02:00
Mats Erik Andersson
c1b5e820f7 ftpd: Group name matching. 2013-06-17 15:13:59 +02:00
Mats Erik Andersson
342261ea9e ftpd: Erroneous access check. 2013-06-17 14:34:50 +02:00
Mats Erik Andersson
d1d52cce92 Update copyright years with 2013. (silent change) 2013-05-22 21:03:41 +02:00
Mats Erik Andersson
0b845519d6 Mixed compiler warnings. 2013-05-22 18:09:42 +02:00
Mats Erik Andersson
9e1ff87298 ftpd: Account expiration. 2013-05-02 23:01:42 +02:00
Mats Erik Andersson
139b77d078 ftpd: Portability of PAM to Solaris. 2013-03-21 14:47:12 +01:00
Mats Erik Andersson
601105eae5 ftpd: Support PAM beyond Linux-PAM. 2013-03-20 21:03:51 +01:00
Mats Erik Andersson
6e7f3881c0 Code formatting (silent change).
ftpd/ftpcmd.y: Close in on GNU coding standard.
2013-02-28 15:09:42 +01:00
Guillem Jover
b1d8390d0a Cleanup automake variables. 2013-01-24 15:20:39 +01:00
Mats Erik Andersson
e1c5c5849a ftpd: Glob overflow and dereference. 2012-10-28 12:13:53 +01:00
Mats Erik Andersson
cc2173d24f ftpd: PAM messaging robustness. 2012-10-26 15:06:13 +02:00
Mats Erik Andersson
430bcddb8c ftpd: User session close down. 2012-10-18 22:40:33 +02:00
Mats Erik Andersson
d8342b4732 ftpd: Prevent privilege escalation. 2012-10-18 22:40:33 +02:00
Mats Erik Andersson
c235508d8d rlogind: Support libwrap in daemon mode. 2012-10-09 21:47:32 +02:00
Mats Erik Andersson
066ab95148 Overflow protection. 2012-10-03 22:20:14 +02:00
Mats Erik Andersson
fc8280bc58 Consistency checks. 2012-09-19 12:14:55 +02:00
Mats Erik Andersson
9aa72c7a97 Configuration of library linkage. 2012-09-13 21:59:16 +02:00