137 Commits

Author SHA1 Message Date
Simon Josefsson
8e9d7c933a doc: Fix codespell nits 2025-11-27 00:33:35 +01:00
Simon Josefsson
04c3738a6c maint: Run 'make update-copyright'. 2025-01-01 18:21:25 +01:00
Collin Funk
e5a9384c92 maint: Remove unnecessary standard library extern function decls.
* ftp/cmds.c (account, user): Don't declare getpass since it is
defined in unistd.h.
* ftp/ftp.c (login): Likewise. Don't declare fclose and pclose since
they are defined in stdio.h.
* ftpd/extern.h: Don't declare getusershell since it is defined in
unistd.h.
* ftpd/ftpd.c: Don't declare fclose since it is defined in stdio.h.
* libinetutils/logwtmp.c: Don't declare errno since it is defined in
errno.h.
* libtelnet/misc.c (auth_encrypt_user): Include string.h and don't
declare strdup.
* telnet/authenc.c (telnet_gets):  Don't declare getpass since it is
defined in unistd.h.
* telnet/commands.c (hostname): Use NULL instead of 0.
(env_init, shell): Include string.h and don't redeclare functions.
2024-05-08 20:29:36 -07:00
Collin Funk
b5888324ce Fix sc_unsigned_int checks.
* ftpd/ftpd.c (send_data, receive_data): Convert 'u_int' to
'unsigned int'.
* libinetutils/ttymsg.c (inetutils_ttymsg): Likewise.
* libls/extern.h: Likewise.
* libls/print.c (minor, printtype): Likewise.
* libls/stat_flags.c (flags_to_string, string_to_flags): Likewise.
* src/rlogin.c (winsize, get_window_size, getescape): Likewise.
* src/rsh.c (copyargs): Likewise.
2024-05-04 01:42:20 -07:00
Simon Josefsson
aba8d6528e maint: Run 'make update-copyright'. 2024-01-01 11:28:59 +01:00
Simon Josefsson
2cf199580a maint: Re-indent using GNU indent 2.2.13. 2023-12-29 18:35:01 +01:00
Jeffrey Bencteux
e4e65c03f4 ftpd,rcp,rlogin,rsh,rshd,uucpd: fix: check set*id() return values
Several setuid(), setgid(), seteuid() and setguid() return values
were not checked in ftpd/rcp/rlogin/rsh/rshd/uucpd code potentially
leading to potential security issues.

Signed-off-by: Jeffrey Bencteux <jeffbencteux@gmail.com>
Signed-off-by: Simon Josefsson <simon@josefsson.org>
2023-07-31 13:58:34 +02:00
Simon Josefsson
4bfe18d36f maint: Run 'make update-copyright'. 2023-01-01 01:37:41 +01:00
Simon Josefsson
c1b8d134d5 Indent code. 2022-10-26 00:03:45 +02:00
Alfred M. Szmidt
6d519229fa Happy GNU 2022 year! 2022-01-01 17:23:02 +01:00
Simon Josefsson
1d5c923528 maint: Use copyright year ranges for readability.
* cfg.mk (update-copyright-env): Add, from coreutils.
(VC_LIST_ALWAYS_EXCLUDE_REGEX): Add, for update-copyright exceptions.
* README: Add info about copyright year ranges.
* *: Update copyright notices.
2021-09-03 18:41:09 +02:00
Simon Josefsson
0ceee23262 Use gnulib module 'attribute' instead of obsolete 'snippets/unused-parameters'.
* */*.c: Use MAYBE_UNUSED instead of _GL_UNUSED_PARAMETER.
* */*.c: Include attribute.h instead of unused-parameters.h.
2021-09-01 22:49:18 +02:00
Alfred M. Szmidt
911413ea57 Happy GNU 2021 year! 2021-01-01 11:35:27 +01:00
Tim Rühsen
46def33024 ftpd: Fix multiple definition of 'errcatch' (gcc 10) 2020-02-29 18:37:20 +01:00
Mats Erik Andersson
71ece60ff8 Minor portability glitches in Solaris and in AIX. 2020-01-18 17:47:05 +01:00
Simon Josefsson
d8de4587f2 Update copyright years to use intervals up to 2020. 2020-01-01 13:21:37 +01:00
Alfred M. Szmidt
7f221ff1f9 ftpd/ftpd.c (options) <max-timeout>: Mention mandatory argument. 2017-07-10 19:59:44 +00:00
Mats Erik Andersson
3d64a8c728 Update copyright years to 2017. (silent change) 2017-02-21 14:25:23 +01:00
Mats Erik Andersson
84dcf08568 Update copyright years to 2016. (silent change) 2016-01-22 19:09:49 +01:00
Mats Erik Andersson
055ea0a73f Fix sc_prohibit_double_semicolon. 2015-04-17 15:38:22 +02:00
Mats Erik Andersson
d3c9b1b8fa Update copyright years with 2015. (silent change) 2015-01-16 14:09:44 +01:00
Mats Erik Andersson
ae85332551 Update copyright years with 2014. (silent change) 2014-01-18 12:23:21 +01:00
Mats Erik Andersson
00eb52f913 ftpd: Follow RFC 2577 by default.
With the aim of preventing user name enumeration,
the standard behaviour is changed to fake a password
exchange when a user name fails to exist.
2013-12-13 12:09:11 +01:00
Mats Erik Andersson
58da4a7168 ftp: Abort transfer in ascii mode. 2013-09-26 01:23:55 +02:00
Mats Erik Andersson
06123506ea ftpd: Status reveals timeout. 2013-08-31 01:46:25 +02:00
Mats Erik Andersson
7795fb389e ftpd: Prevent disclosure of system version. 2013-06-26 19:07:30 +02:00
Mats Erik Andersson
d1d52cce92 Update copyright years with 2013. (silent change) 2013-05-22 21:03:41 +02:00
Mats Erik Andersson
9e1ff87298 ftpd: Account expiration. 2013-05-02 23:01:42 +02:00
Mats Erik Andersson
601105eae5 ftpd: Support PAM beyond Linux-PAM. 2013-03-20 21:03:51 +01:00
Mats Erik Andersson
cc2173d24f ftpd: PAM messaging robustness. 2012-10-26 15:06:13 +02:00
Mats Erik Andersson
430bcddb8c ftpd: User session close down. 2012-10-18 22:40:33 +02:00
Mats Erik Andersson
d8342b4732 ftpd: Prevent privilege escalation. 2012-10-18 22:40:33 +02:00
Mats Erik Andersson
fc8280bc58 Consistency checks. 2012-09-19 12:14:55 +02:00
Mats Erik Andersson
a69f322c04 ftpd, libls: Compiler warnings. 2012-09-13 21:59:14 +02:00
Mats Erik Andersson
8ee8d9acbd ftpd: Audit of PAM code. 2012-06-07 21:05:13 +02:00
Mats Erik Andersson
5f1d3b85b5 ftpd: Only allow Linux-PAM.
The existing code is only working with
the variant Linux-PAM. Adapt to this fact.
2012-06-07 21:05:13 +02:00
Mats Erik Andersson
3370c78d40 ftpd: Long passive transfer request.
Add the command request `LPSV'.
2012-06-02 00:27:52 +02:00
Mats Erik Andersson
ac18df39a8 ftpd: Adaptive block sizes.
Improve throughput by use of block sizes
as reported by file system data.
2012-05-31 01:21:51 +02:00
Mats Erik Andersson
2aea8c1ea8 Incomplete variadic printing.
Missing va_start() and va_end() cause crashes.
2012-05-30 23:09:18 +02:00
Mats Erik Andersson
b0a461970a ftpd: Grave binary mode issues.
Empty buffer allocation and 64-bit artifacts.
2012-05-30 23:09:17 +02:00
Mats Erik Andersson
c76e1f1f05 ftpd: Incomplete access verification. 2012-04-13 21:24:25 +02:00
Mats Erik Andersson
f01c9cc6b3 ftpd: Standalone-mode with IPv6.
Command line options determine in standalone-mode whether
to start a single stacked service, or a dual stacked service.
2012-01-22 17:33:44 +01:00
Mats Erik Andersson
2d945ae465 ftpd: Inetd-mode with EPRT and EPSV.
Provide tested IPv6 support in inetd-mode, with special
care to IPv4-mapped-IPv6 addressing also in legacy mode.
2012-01-22 17:30:04 +01:00
Simon Josefsson
0448969ce2 ftpd/ftpd.c (options): Don't use OPTION_ARG_OPTIONAL for -a. 2012-01-18 11:03:45 +01:00
Mats Erik Andersson
dd43de5f41 ftpd: Regression with active connections.
In using an active connection, the port was not cleared properly,
leading to a missed port allocation in bind().  A minor portability
issue lead to change of hints for getaddrinfo() in resolving `host_port'.
2012-01-04 18:33:06 +01:00
Mats Erik Andersson
01dd21c666 ftpd: Internal address family independence. 2012-01-03 00:45:44 +01:00
Mats Erik Andersson
ed4ff5db99 ftpd: First step for address independence. 2012-01-02 22:29:14 +01:00
Alfred M. Szmidt
99c71142f2 Updated copyright years; happy 2012! (silent change) 2012-01-01 19:27:00 +01:00
Alfred M. Szmidt
1a343be8d0 Fix prohibit_dirent_without_use, sc_unsigned_short, sc_unsigned_long sc_unsigned_char checks. 2011-12-30 18:49:49 +01:00
Mats Erik Andersson
4a11f3a095 ftp,ftpd,rcp: Portable format string for long long. 2011-12-30 10:58:18 +01:00