79 Commits

Author SHA1 Message Date
Simon Josefsson
8e9d7c933a doc: Fix codespell nits 2025-11-27 00:33:35 +01:00
Simon Josefsson
04c3738a6c maint: Run 'make update-copyright'. 2025-01-01 18:21:25 +01:00
Collin Funk
dd4c077b34 maint: Fix most instances of '-Wstrict-prototypes'.
* libinetutils/des_rw.c (des_clear_key, des_read, des_write): Don't
use K&R-style function declarations.
* ifconfig/system/linux.c (pnd_read): Use void instead of an empty
argument list.
* libtelnet/auth.c (auth_status, auth_request, auth_send_retry):
Likewise.
* libtelnet/kerberos5.c (kerberos5_cleanup): Likewise.
* ping/ping.c (ping_run): Likewise.
* ping/ping6.c (ping_run): Likewise.
* ping/ping6.h (ping_run): Likewise.
* ping/ping_impl.h (ping_run): Likewise.
* telnet/authenc.c (net_encrypt, telnet_spin): Likewise.
* telnet/commands.c (_setlist_init, auth_help, EncryptHelp)
(ayt_status): Likewise.
* telnet/sys_bsd.c (TerminalNewMode): Likewise.
* telnet/tn3270.c (outputPurge, Push3270, Finish3270, SetIn3270)
(tn3270_ttype): Likewise.
* telnetd/state.c (willoption): Likewise.
* telnetd/telnetd.h (pty_buffer_level): Likewise.
* telnetd/term.c (term_send_eof, term_change_eof, tty_linemode)
(tty_isecho, tty_flowmode, tty_restartany, tty_israw)
(tty_isbinaryin, tty_isbinaryout, tty_isediting, tty_istrapsig)
(tty_issofttab, tty_islitecho, tty_iscrnl, copy_termbuf): Likewise.
* telnetd/termstat.c (termstat, _termstat): Likewise.
* telnetd/utility.c (net_encrypt, telnet_spin): Likewise.
* src/rcp.c (krb_realmofhost): Add the parameter type.
* telnet/ring.c (ring_encrypt): Likewise.
* telnet/ring.h (ring_encrypt): Likewise.
2024-05-09 18:51:54 -07:00
Simon Josefsson
aba8d6528e maint: Run 'make update-copyright'. 2024-01-01 11:28:59 +01:00
Simon Josefsson
4bfe18d36f maint: Run 'make update-copyright'. 2023-01-01 01:37:41 +01:00
Simon Josefsson
c1b8d134d5 Indent code. 2022-10-26 00:03:45 +02:00
Alfred M. Szmidt
6d519229fa Happy GNU 2022 year! 2022-01-01 17:23:02 +01:00
Simon Josefsson
1d5c923528 maint: Use copyright year ranges for readability.
* cfg.mk (update-copyright-env): Add, from coreutils.
(VC_LIST_ALWAYS_EXCLUDE_REGEX): Add, for update-copyright exceptions.
* README: Add info about copyright year ranges.
* *: Update copyright notices.
2021-09-03 18:41:09 +02:00
Michal Ruprich
cd7e7e685d telnetd: Fix arbitrary remote code execution via short writes or urgent data
Fixes: CVE-2020-10188
Closes: #956084
Bug-RedHat: https://bugzilla.redhat.com/show_bug.cgi?id=CVE-2020-10188
Patch-Origin: Fedora / RedHat
Patch-URL: https://src.fedoraproject.org/rpms/telnet/raw/master/f/telnet-0.17-overflow-exploit.patch
Signed-off-by: Simon Josefsson <simon@josefsson.org>
2021-01-29 09:24:40 +01:00
Alfred M. Szmidt
911413ea57 Happy GNU 2021 year! 2021-01-01 11:35:27 +01:00
Tim Rühsen
b09d8a358b telnetd: Silence unused warning for getterminaltype 2020-02-29 19:18:58 +01:00
Tim Rühsen
4114b424a8 telnetd: Fix multiple definition of 'not42' (gcc 10) 2020-02-29 18:37:20 +01:00
Mats Erik Andersson
07fdb4201a More work on CVE-2019-0053.
Telnet protocol messages must remain sane at all costs, instead of
being truncated because indata was oversized.  Some additional cases
of insufficient buffer declaration are corrected.
2020-01-29 21:07:10 +01:00
Mats Erik Andersson
71ece60ff8 Minor portability glitches in Solaris and in AIX. 2020-01-18 17:47:05 +01:00
Simon Josefsson
d8de4587f2 Update copyright years to use intervals up to 2020. 2020-01-01 13:21:37 +01:00
Mats Erik Andersson
9d646ac0f0 telnetd: Portable option debugging.
Also report locally unsupported editing characters
as free for the client to choose at his own will
2017-02-27 23:03:36 +01:00
Mats Erik Andersson
9db2d39777 telnetd: Debugging of line mode options. 2017-02-21 18:50:30 +01:00
Mats Erik Andersson
3d64a8c728 Update copyright years to 2017. (silent change) 2017-02-21 14:25:23 +01:00
Mats Erik Andersson
84dcf08568 Update copyright years to 2016. (silent change) 2016-01-22 19:09:49 +01:00
Mats Erik Andersson
ec8c9a31b4 telnetd: Premature connection closure.
A change, part of 0b7e8687, but secondary to its
intention, turned out to cause service rejects during
conditions akin to connection flooding.  Revert this
particular part to gain established, good behaviour
on GNU/Linux.
Reported in `bug-inetutils/2015-07/msg00006.html'.
2015-08-19 14:26:05 +02:00
Mats Erik Andersson
f09010fcda Portability of time format string. 2015-03-21 23:28:52 +01:00
Mats Erik Andersson
fa3245ac8c telnetd: Enable autologin in legacy mode.
Without authentication, autologin was broken.  Bug reported
by Kuaikuai Wu to the list in `2014-12/msg00010.html'.
2015-03-19 13:49:43 +01:00
Mats Erik Andersson
239949170f telnetd: Incomplete processing of PTY data.
It may happen that an incoming SIGCHLD intervenes with the transfer
of the last few bytes from the PTY of the child process to the net
stream servicing the remote client with response.  Improved signal
handling of SIGCHLD prevents this loss.
2015-01-20 12:46:13 +01:00
Mats Erik Andersson
eaea8e167f telnetd: Inherited mistakes in legacy code. 2015-01-17 02:04:36 +01:00
Mats Erik Andersson
d3c9b1b8fa Update copyright years with 2015. (silent change) 2015-01-16 14:09:44 +01:00
Alfred M. Szmidt
d129f72ed5 * telnetd/utility.c (printsub): Don't add integer to string to try and
skip quote.
2014-07-30 18:18:12 +02:00
Alfred M. Szmidt
e5d2fade3a * telnetd/utility.c (nextitem, netclear, printoption, printsub)
(printdata): Remove register keyword usage.
2014-07-30 18:14:25 +02:00
Mats Erik Andersson
ae85332551 Update copyright years with 2014. (silent change) 2014-01-18 12:23:21 +01:00
Mats Erik Andersson
17518fbec9 rlogind, telnet, telnetd: Modify exit status.
As a side effect, a race condition is now avoided,
while `rlogind' is tearing down pseudo-terminal pairs.
2013-11-28 19:39:38 +01:00
Mats Erik Andersson
d1d52cce92 Update copyright years with 2013. (silent change) 2013-05-22 21:03:41 +02:00
Mats Erik Andersson
a98c1047ac libtelnet: Standard type for strings. 2013-05-22 02:52:32 +02:00
Mats Erik Andersson
e4c1a64a7b telnetd: Silence unwanted debugging.
New debugging mode `encr'.  Do not add text
for `auth' and `encr' into `/tmp/telnet.debug'
without explicit debug setting.
2013-05-14 22:36:33 +02:00
Mats Erik Andersson
3864a49a23 libtelnet: Check authentication name strings.
The list of authentication names is allowed
to set NULL for missing methods.  Protect
against dereferencing such null-pointers.
2013-05-14 17:26:43 +02:00
Mats Erik Andersson
d6a64f4ff8 libtelnet: Availability of DES_OFB64.
Declare properly that our code base supports DES_CFB64
as well as DES_OFB64.  This prevents the system specific
header to arrange matters otherwise.
2013-05-13 23:09:53 +02:00
Mats Erik Andersson
6e8595711a telnet, telnetd: Buffer security. 2013-04-10 16:17:38 +02:00
Mats Erik Andersson
2b21870677 Detection of Kerberos5. 2013-03-22 10:35:06 +01:00
Mats Erik Andersson
e28334cfec telnetd: More compiler warnings. 2012-09-14 14:53:02 +02:00
Mats Erik Andersson
7faf49c035 telnetd: Compiler warnings. 2012-09-14 00:35:47 +02:00
Simon Josefsson
ca404fb908 Use 2kb buffer, as suggested by GNU termcap manual.
Tiny patch from Petr Malát  <oss@malat.biz>.
2012-08-24 09:09:44 +02:00
Simon Josefsson
b189c9e69b Don't busy loop when waiting for data from client.
Tiny patch from Petr Malát <oss@malat.biz>.
2012-08-24 09:08:01 +02:00
Mats Erik Andersson
3a870c0123 telnetd: Effective authentication modes. 2012-07-16 17:42:21 +02:00
Mats Erik Andersson
217f5157bc telnetd: Authmode only with Kerberos. 2012-07-16 17:42:21 +02:00
Alfred M. Szmidt
8173030af2 Revert to commit 99c71142f2. (silent
change)
2012-02-26 21:01:56 +01:00
Alfred M. Szmidt
d7be6fbb79 bootstrap.conf (gnulib_modules): Sort lexically. 2012-02-25 12:31:23 +01:00
Alfred M. Szmidt
99c71142f2 Updated copyright years; happy 2012! (silent change) 2012-01-01 19:27:00 +01:00
Mats Erik Andersson
5051e7b67b Termcap and readline portability.
Refine readline and tgetent autodetection
to achieve full support for NetBSD.
2011-12-13 12:32:41 +01:00
Mats Erik Andersson
c310f1175d telnet,telnetd: Fix ncurses/termio for Solaris. 2011-12-09 16:17:08 +01:00
Mats Erik Andersson
a1e37953a3 telnet,telnetd: Build fix for recent readline support.
Condition on HAVE_READLINE, not HAVE_LIBREADLINE.
2011-11-19 11:49:12 +01:00
Mats Erik Andersson
0a83fb189c telnet,telnetd: Portability to GNU/OpenSolaris.
Some standard header inclusions were missing.
2011-11-17 22:10:05 +01:00
Alfred M. Szmidt
d9788a7d35 Updated copyright years; happy 2011! (silent change) 2011-01-02 15:23:38 +00:00