Mirsad Todorovac
336c218dd7
mtd: slram: insert break after errors in parsing the map
GCC 12.3.0 compiler on linux-next next-20240709 tree found the execution
path in which, due to lazy evaluation, devlength isn't initialised with the
parsed string:
289 while (map) {
290 devname = devstart = devlength = NULL;
291
292 if (!(devname = strsep(&map, ","))) {
293 E("slram: No devicename specified.\n");
294 break;
295 }
296 T("slram: devname = %s\n", devname);
297 if ((!map) || (!(devstart = strsep(&map, ",")))) {
298 E("slram: No devicestart specified.\n");
299 }
300 T("slram: devstart = %s\n", devstart);
→ 301 if ((!map) || (!(devlength = strsep(&map, ",")))) {
302 E("slram: No devicelength / -end specified.\n");
303 }
→ 304 T("slram: devlength = %s\n", devlength);
305 if (parse_cmdline(devname, devstart, devlength) != 0) {
306 return(-EINVAL);
307 }
Parsing should be finished after map == NULL, so a break is best inserted after
each E("slram: ... \n") error message.
Fixes: 1da177e4c3 ("Linux-2.6.12-rc2")
Cc: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: Vignesh Raghavendra <vigneshr@ti.com>
Cc: linux-mtd@lists.infradead.org
Signed-off-by: Mirsad Todorovac <mtodorovac69@gmail.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20240711234319.637824-1-mtodorovac69@gmail.com
2024-08-23 19:25:46 +02:00
..
2024-07-27 10:14:34 -07:00
2024-07-19 15:55:08 -07:00
2024-07-26 11:04:28 -07:00
2024-07-27 12:26:09 -07:00
2024-07-27 15:28:53 -07:00
2024-07-19 11:57:55 -07:00
2024-07-27 12:46:16 -07:00
2024-07-24 20:59:29 +02:00
2024-07-24 20:59:29 +02:00
2024-07-27 12:46:16 -07:00
2024-07-25 06:53:47 -05:00
2024-07-19 15:55:08 -07:00
2024-07-20 12:41:03 -07:00
2024-07-28 09:33:28 -07:00
2024-07-25 10:42:22 -07:00
2024-07-25 10:42:22 -07:00
2024-07-25 10:42:22 -07:00
2024-07-21 17:15:46 -07:00
2024-07-28 13:41:14 -07:00
2024-07-25 10:42:22 -07:00
2024-07-27 10:14:34 -07:00
2024-07-25 10:42:22 -07:00
2024-07-25 10:42:22 -07:00
2024-07-27 12:54:06 -07:00
2024-07-28 13:41:14 -07:00
2024-07-25 10:42:22 -07:00
2024-07-25 10:42:22 -07:00
2024-07-25 10:42:22 -07:00
2024-07-25 10:42:22 -07:00
2024-07-19 15:55:08 -07:00
2024-07-25 10:42:22 -07:00
2024-07-25 10:42:22 -07:00
2024-07-27 10:53:06 -07:00
2024-07-25 06:53:47 -05:00
2024-07-19 09:59:58 -07:00
2024-07-25 10:42:22 -07:00
2024-07-19 15:55:08 -07:00
2024-07-27 12:39:55 -07:00
2024-07-25 06:53:47 -05:00
2024-07-25 08:05:05 -07:00
2024-07-25 12:58:36 -07:00
2024-07-19 21:25:23 -05:00
2024-07-25 10:42:22 -07:00
2024-07-28 13:41:14 -07:00
2024-07-26 10:26:33 -07:00
2024-07-25 10:42:22 -07:00
2024-07-27 12:46:16 -07:00
2024-07-25 10:42:22 -07:00
2024-07-25 10:42:22 -07:00
2024-07-25 10:42:22 -07:00
2024-08-23 19:25:46 +02:00
2024-07-28 13:41:14 -07:00
2024-07-25 10:42:22 -07:00
2024-07-25 10:42:22 -07:00
2024-07-26 08:06:15 -06:00
2024-07-25 10:42:22 -07:00
2024-07-19 09:59:58 -07:00
2024-07-25 12:58:36 -07:00
2024-07-25 10:42:22 -07:00
2024-07-25 10:42:22 -07:00
2024-07-25 10:42:22 -07:00
2024-07-27 10:14:34 -07:00
2024-07-24 13:11:28 -07:00
2024-07-25 06:53:47 -05:00
2024-07-25 10:42:22 -07:00
2024-07-23 09:38:27 -07:00
2024-07-25 10:42:22 -07:00
2024-07-25 06:53:47 -05:00
2024-07-27 12:27:52 -07:00
2024-07-23 13:41:59 -07:00
2024-07-25 10:42:22 -07:00
2024-07-25 10:42:22 -07:00
2024-07-26 10:47:53 -07:00
2024-07-25 10:42:22 -07:00
2024-07-25 10:42:22 -07:00
2024-07-25 10:42:22 -07:00
2024-07-25 10:42:22 -07:00
2024-07-25 10:42:22 -07:00
2024-07-27 12:29:10 -07:00
2024-07-25 10:42:22 -07:00
2024-07-25 10:42:22 -07:00
2024-07-25 10:42:22 -07:00
2024-07-24 12:40:23 +02:00
2024-07-25 10:42:22 -07:00
2024-07-27 12:46:16 -07:00
2024-07-19 10:56:58 -07:00
2024-07-27 12:46:16 -07:00
2024-07-25 10:42:22 -07:00
2024-07-25 10:42:22 -07:00
2024-07-19 11:57:55 -07:00
2024-07-21 17:15:46 -07:00
2024-07-20 12:41:03 -07:00
2024-07-25 10:42:22 -07:00
2024-07-25 10:18:35 -07:00
2024-07-25 10:42:22 -07:00
2024-07-25 10:42:22 -07:00