breeze/gpac
1
0
Fork 0
mirror of https://github.com/gpac/gpac.git synced 2026-01-12 00:05:22 +08:00
Code Issues Packages Projects Releases Wiki Activity

fixed potential race condition leading to crash in filter_remove_iternal

Browse Source
This commit is contained in:
Jean Le Feuvre
2025-12-19 18:32:46 +01:00
parent c78b566358
commit fc32030735
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/filter_core/filter.c
View File

@@ -3881,6 +3881,12 @@ void gf_filter_remove_internal(GF_Filter *filter, GF_Filter *until_filter, Bool
} else {
GF_LOG(GF_LOG_INFO, GF_LOG_FILTER, ("Disconnecting filter %s from session\n", filter->name));
}
//lock before the loop for multithreaded cases:
//1- gf_fs_post_disconnect_task can be called, triggering a filter_post_remove
//2- the filter_remove could be executed before we reach the end of the loop, hence crash
//By locking, we'll force filter_post_remove to wait
gf_mx_p(filter->tasks_mx);
//get all dest pids, post disconnect and mark filters as removed
gf_assert(!filter->removed);
filter->removed = 1;
@@ -3901,7 +3907,6 @@ void gf_filter_remove_internal(GF_Filter *filter, GF_Filter *until_filter, Bool
}
}
}
gf_mx_p(filter->tasks_mx);
if (!filter->num_output_pids && !filter->num_input_pids) {
gf_filter_post_remove(filter);