breeze/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-01-25 15:03:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

rtc: pm8xxx: fix possible race condition

Browse Source 
probe must not fail after devm_rtc_register_device is successful because
the character device will be seen by userspace and may be opened right
away. Call it last to avoid opening the race window.

Link: https://lore.kernel.org/r/20250303223600.1135142-2-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
This commit is contained in:
Alexandre Belloni
2025-03-03 23:35:57 +01:00
parent de404fc196
commit 252f49cd71
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/rtc/rtc-pm8xxx.c
View File

@@ -519,11 +519,11 @@ static int pm8xxx_rtc_probe(struct platform_device *pdev)
if (rc < 0)
return rc;
rc = devm_rtc_register_device(rtc_dd->rtc);
rc = devm_pm_set_wake_irq(&pdev->dev, rtc_dd->alarm_irq);
if (rc)
return rc;
return devm_pm_set_wake_irq(&pdev->dev, rtc_dd->alarm_irq);
return devm_rtc_register_device(rtc_dd->rtc);
}
static struct platform_driver pm8xxx_rtc_driver = {