mirror of
https://github.com/torvalds/linux.git
synced 2026-01-12 00:42:35 +08:00
net: mdio: rtl9300: use scoped for loops
Currently in the return path, fwnode_handle_put calls are missing. Just use
_scoped to avoid the issue.
Fixes: 24e31e4747 ("net: mdio: Add RTL9300 MDIO driver")
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Link: https://patch.msgid.link/20251217210153.14641-1-rosenp@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
This commit is contained in:
@@ -354,7 +354,6 @@ static int rtl9300_mdiobus_probe_one(struct device *dev, struct rtl9300_mdio_pri
|
||||
struct fwnode_handle *node)
|
||||
{
|
||||
struct rtl9300_mdio_chan *chan;
|
||||
struct fwnode_handle *child;
|
||||
struct mii_bus *bus;
|
||||
u32 mdio_bus;
|
||||
int err;
|
||||
@@ -371,7 +370,7 @@ static int rtl9300_mdiobus_probe_one(struct device *dev, struct rtl9300_mdio_pri
|
||||
* compatible = "ethernet-phy-ieee802.3-c45". This does mean we can't
|
||||
* support both c45 and c22 on the same MDIO bus.
|
||||
*/
|
||||
fwnode_for_each_child_node(node, child)
|
||||
fwnode_for_each_child_node_scoped(node, child)
|
||||
if (fwnode_device_is_compatible(child, "ethernet-phy-ieee802.3-c45"))
|
||||
priv->smi_bus_is_c45[mdio_bus] = true;
|
||||
|
||||
@@ -409,7 +408,6 @@ static int rtl9300_mdiobus_map_ports(struct device *dev)
|
||||
{
|
||||
struct rtl9300_mdio_priv *priv = dev_get_drvdata(dev);
|
||||
struct device *parent = dev->parent;
|
||||
struct fwnode_handle *port;
|
||||
int err;
|
||||
|
||||
struct fwnode_handle *ports __free(fwnode_handle) =
|
||||
@@ -418,7 +416,7 @@ static int rtl9300_mdiobus_map_ports(struct device *dev)
|
||||
return dev_err_probe(dev, -EINVAL, "%pfwP missing ethernet-ports\n",
|
||||
dev_fwnode(parent));
|
||||
|
||||
fwnode_for_each_child_node(ports, port) {
|
||||
fwnode_for_each_child_node_scoped(ports, port) {
|
||||
struct device_node *mdio_dn;
|
||||
u32 addr;
|
||||
u32 bus;
|
||||
|
||||
Reference in New Issue
Block a user